Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legends in visualizations #6632

Merged
merged 5 commits into from
May 2, 2024
Merged

Fix legends in visualizations #6632

merged 5 commits into from
May 2, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Apr 29, 2024 •
edited
Loading

Description

The main goal of this pull request is to remove all the Count legends (when the data is not aggregated by any field) in the visualizations because it's not useful.

The changes made were:

  • Removes the "Count" labels in visualizations.
  • Removes the "Top requirements over time" visualization
  • Aggregates the "Top 10 PCI DSS requirements" values by rule.pci_dss
  • Adds a minor fix in the configuration-switch.js component
    • This excludes evaluating the Wazuh manager's state when trying to access Server management -> Settings view

Issues Resolved

Closes #6628

Tests & Evidence

PCI DSS
  • Segregate the Top 10 PCI DSS requirements visualization by rule.pci_dss
  • Remove Top requirements over time visualization

screencapture-localhost-5601-app-pci-dss-2024-05-02-09_59_56

Google Cloud

With a pinned agent

  • Remove the Count label from the GCP alerts evolution visualization and the Auth answer count visualization

screencapture-localhost-5601-app-google-cloud-2024-05-02-10_09_21

HIPAA

With a pinned agent

  • Remove the Count label from the Most common alerts visualization

screencapture-localhost-5601-app-hipaa-2024-05-02-10_12_19

GDPR
  • Add the rule.gdpr field label in the GDPR requirements visualization

screencapture-localhost-5601-app-gdpr-2024-05-02-10_15_18

Malware Detection
  • Remove the Count label from the Malware activity visualization

screencapture-localhost-5601-app-malware-detection-2024-05-02-10_18_18

Server management -> Settings
  • Verify the view loads the settings

image

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Apr 29, 2024
@asteriscos asteriscos linked an issue Apr 29, 2024 that may be closed by this pull request
Refine dashboards visualizations #6628
Closed
3 tasks
@asteriscos asteriscos marked this pull request as ready for review May 2, 2024 08:41
@asteriscos asteriscos changed the title Remove count label and PCI-DSS-Requirements-over-time redundant visua… Fix legends in visualizations May 2, 2024
@Desvelao
Copy link
Member

Desvelao commented May 2, 2024

Test 🟢

PCI DSS
image

GCP
image

HIPPA
image

Malware activity
image

Server management > Settings
image

Desvelao
Desvelao reviewed May 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Desvelao
Desvelao approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JuanGarriuz JuanGarriuz self-requested a review May 2, 2024 10:51
@JuanGarriuz
Copy link
Member

Tests & Evidence

PCI DSS 🟢

image

Google Cloud 🟢

image
image

HIPAA 🟢

image

GDPR 🟢

image

Malware Detection 🟢

image

Server management -> Settings 🟢

image

JuanGarriuz
JuanGarriuz approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit 5b2205c into 4.8.0 May 2, 2024
1 check passed
@asteriscos asteriscos deleted the enhance/refine-dashboards-visualizations-6628 branch May 2, 2024 12:10
@asteriscos asteriscos mentioned this pull request May 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine dashboards visualizations
3 participants
@asteriscos @Desvelao @JuanGarriuz